vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

Boltz #482

Closed Janaka-Steph closed 8 months ago

Janaka-Steph commented 1 year ago

This PR implements submarine swaps between L-BTC and Lightning (using Boltz):

tiero commented 9 months ago

Feel free to commit to the branch adding Stephane remote @bordalix

bordalix commented 9 months ago

Feel free to commit to the branch adding Stephane remote @bordalix

I think I don't have the right permissions to write on Stephane repo.

tiero commented 9 months ago

Maybe you have to have write permissions to upstream. Maybe just merge it in another branch of yours and re-open a PR

bordalix commented 9 months ago

Maybe you have to have write permissions to upstream. Maybe just merge it in another branch of yours and re-open a PR

Steph just gave me writing permissions to his repo, now pushing to this PR directly.

bordalix commented 9 months ago

For testing (commit 197a275)

marina-0.5.2-manifest-v2.zip marina-0.5.2-manifest-v3.zip

tiero commented 9 months ago

Tested on Liquid mainnet #ReckLess

image
michael1011 commented 9 months ago

Tested on Liquid mainnet #ReckLess

image

non-final means that you are trying to broadcast a transaction before its locktime has been reached

https://learnmeabitcoin.com/technical/locktime

socket-security[bot] commented 9 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
bolt11 1.4.1 filesystem, environment +9 3.12 MB junderw
bordalix commented 9 months ago

Let's have two rows for Liquid Bitcoin and the Any asset on this screen. When user selct Liquid Bitcoin, there is the modal for choice between LQ and LN

For Any asset, it goes directly to Liquid instead

image

Fixed by 469514b

tiero commented 9 months ago

Paste the invoice in the Send flow and click on Proceed

lnbc44110n1pjcrzg4pp54xpjkfaul2w9cf5dwu528chgyk9altwnew507e4t72fz8wj0x2lqdqqcqzzsxqyz5vqsp5qqm3zmektlxmdu8z00ezyk7r9vs0m2hg7ytpwp9j2p0mvg7m3dpq9qyyssq3cnkd2qrxrzwgz8x2l2d0g9x9cglyyu5mssvzdgm489arjeylmr3n0agpc96yanrvxcgmmvtnydarm6lhrdrqz6n8rzun03wr0eu2eqqg2zzwm
tiero commented 9 months ago
Warning: Hash history cannot PUSH the same path; a new entry will not be added to the history stack

https://www.loom.com/share/8c07a96daa394ff995bafccca2594ef6

bordalix commented 9 months ago
Warning: Hash history cannot PUSH the same path; a new entry will not be added to the history stack

https://www.loom.com/share/8c07a96daa394ff995bafccca2594ef6

@tiero fixed by fbb4d20a

bordalix commented 9 months ago

Paste the invoice in the Send flow and click on Proceed

lnbc44110n1pjcrzg4pp54xpjkfaul2w9cf5dwu528chgyk9altwnew507e4t72fz8wj0x2lqdqqcqzzsxqyz5vqsp5qqm3zmektlxmdu8z00ezyk7r9vs0m2hg7ytpwp9j2p0mvg7m3dpq9qyyssq3cnkd2qrxrzwgz8x2l2d0g9x9cglyyu5mssvzdgm489arjeylmr3n0agpc96yanrvxcgmmvtnydarm6lhrdrqz6n8rzun03wr0eu2eqqg2zzwm

@tiero fixed by 02877876e5

tiero commented 8 months ago

Build for Chrome from latest commit

marina-0.5.7.zip