vulpemventures / marina

Liquid Wallet browser extension
MIT License
35 stars 16 forks source link

SignerService: request signature using BIP32Derivation field #494

Closed louisinger closed 10 months ago

louisinger commented 10 months ago

TL;DR

Note that the fields fingerPrint and path are not used because Marina is mapping derivation path to script. Instead this PR uses a trick to re-compute the P2WPKH script from publicKey field. In other words your only need to set up a marina public public in the input to request a signature.

try it yourself: marina-0.5.4.zip

jamesdorfman commented 10 months ago

Great work, thank you. tACK 5888ff3ae1a50203274350402aee0edf71d487cd.

Marina successfully signed my PSET when I provided a Bip32Derivation.