search

vulpemventures / neutrino-elements

MIT License
3 stars 4 forks source link

Persistent layer & Docker setup #28

Closed sekulicd closed 2 years ago

sekulicd commented 2 years ago

This contains postgres db layer implementation, docker setup and update of GH action.

This closes #24 This closes #27 This closes #26

PR #24 should be closed.

@tiero please review.

tiero commented 2 years ago

because they couldn't be used externally

I think the idea was to NOT be used externally, but only by neutrinod the standalone daemon we offer in the same repo

sekulicd commented 2 years ago

Also, I'm not so convinced that subscribing for spent/unspent utxos in neutrinod is ideal for UX. I would need to make 2 subscription to be notified of my utxo pool this way. Instead, 2 topics that make more sense to me are "transactions" and "utxos" (which are the abstractions built on top of neutrino scanner tx reports in vv/ocean). The idea is to get notified about every tx or utxo of interest, with the payload carrying the spent/unspent and confirmed/unconfirmed status.

Regarding above, as there was no precise requirement on api spec i suggest we move this to another issue with clear definitions. My initial goal was to be flexible enough by adding option to provide slice of events (here). We can define any event we want. But yeah, i suggest to move this to another issue. @tiero @altafan

tiero commented 2 years ago

Merging and moving to new issue