vulpemventures / ocean

:ocean: Elements/Liquid wallet daemon
MIT License
5 stars 7 forks source link

Psetv2: `Output` message should have a blinder index field #21

Closed louisinger closed 1 year ago

louisinger commented 1 year ago

https://github.com/vulpemventures/ocean/blob/master/api-spec/protobuf/ocean/v1/types.proto#L42

tiero commented 1 year ago

also, address should be split in script & blind pub key, so we can pass op_return and future segwit versions

louisinger commented 1 year ago

also, address should be split in script & blind pub key, so we can pass op_return and future segwit versions

address is OK for segwit version, script and blind pubkey and easier to read in my opinion. I prefer an optional parameter "script" in order to handle OP_RETURN (or whatever not encodable via address)

tiero commented 1 year ago

also, address should be split in script & blind pub key, so we can pass op_return and future segwit versions

address is OK for segwit version, script and blind pubkey and easier to read in my opinion. I prefer an optional parameter "script" in order to handle OP_RETURN (or whatever not encodable via address)

yes having addres AND script is fine, but you need also blinding pub key, in case of confidential OP_RETURN

altafan commented 1 year ago

Closed by #23