Closed sekulicd closed 1 year ago
I see most of comments are related to the request to abstract away from user namespace/label columns into one called(account, accountName, name). For UX perspective this is better option but it adds bit of complexity to the backend, since we dont know wether user passed namespace or label we need to have two maps accountsPerNamespace and accountsPerLaber in order to support search "1 in 2(one field that could mean two things)", we need to update repositories as well. Field previously called accountName was all over the code base and wanted to be consistent, so the code is more readable and that person who reads it can recognise same arg name everywhere wether it is in scanners or repos or somewhere else.
So se this was already big change, it we want to go with the requirement to allow user to search in one filed using namespace/label please suggest how we want to call and i suggest to use it everywhere.
WDYT @tiero @altafan ?
Would starting with namespace only enough for time being? Will refactor later to add label?
So se this was already big change, it we want to go with the requirement to allow user to search in one filed using namespace/label please suggest how we want to call and i suggest to use it everywhere.
Let's refer internally to an account just as account
, like for example in utxos, transactions, scanners etc.
Let's use instead name
to allow the user refer to an account (protobuf), whether he's passing a namespace or label. Let's keep using the flag --account-name without changing it.
The only place where we need to make an explicit distinction between namespace and label is in the creation of the wallet and for setting an account label.
@sekulicd do you agree?
@altafan please check now.
This contains too many unnecessary changes. We can eventually recover the work done here to refactor the tests to open a dedicated PR. Closing in favour of #49.
Changes:
This closes #44 This closes #15
@tiero @altafan please review.