vulsio / go-exploitdb

Tool for searching Exploits from Exploit Databases, etc.
MIT License
249 stars 56 forks source link

breaking-change(redis): deprecated expire option #66

Closed MaineK00n closed 3 years ago

MaineK00n commented 3 years ago

What did you implement:

Expire was introduced to ensure safe operation in Redis, but since expire can only be set per key, it is not very useful for Sets and Hash. Therefore, if there is any old content in each fetch, it will be deleted.

Type of change

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

Is this ready for review?: NO

Reference

kotakanbe commented 3 years ago
 ubuntu@dev  ~│g│s│g│v│go-exploitdb  ⎇ MaineK00n/deprecated-expire~  ./integration/exploitdb.old version
go-exploitdb v0.4.1 3c58fdc
 ubuntu@dev  ~│g│s│g│v│go-exploitdb  ⎇ MaineK00n/deprecated-expire~  ./integration/exploitdb.new version
go-exploitdb v0.4.1 67d6612
 ubuntu@dev  ~│g│s│g│v│go-exploitdb  ⎇ MaineK00n/deprecated-expire~  make diff-server-redis
integration/exploitdb.old server --dbtype redis --dbpath "redis://127.0.0.1:6379/0" --port 1325 > /dev/null 2>&1 &
integration/exploitdb.new server --dbtype redis --dbpath "redis://127.0.0.1:6380/0" --port 1326 > /dev/null 2>&1 &
make diff-cveid
make[1]: Entering directory '/home/ubuntu/go/src/github.com/vulsio/go-exploitdb'
INFO[10-04|08:30:33] start server mode test(mode: cveid)
INFO[10-04|08:30:33] check the communication with the server
INFO[10-04|08:30:33] communication with the server has been confirmed
INFO[10-04|08:30:35] start server mode test(mode: cveids)
INFO[10-04|08:30:35] check the communication with the server
INFO[10-04|08:30:35] communication with the server has been confirmed
make[1]: Leaving directory '/home/ubuntu/go/src/github.com/vulsio/go-exploitdb'
make diff-uniqueid
make[1]: Entering directory '/home/ubuntu/go/src/github.com/vulsio/go-exploitdb'
INFO[10-04|08:30:35] start server mode test(mode: uniqueid)
INFO[10-04|08:30:35] check the communication with the server
INFO[10-04|08:30:35] communication with the server has been confirmed
INFO[10-04|08:30:40] start server mode test(mode: uniqueids)
INFO[10-04|08:30:40] check the communication with the server
INFO[10-04|08:30:40] communication with the server has been confirmed
make[1]: Leaving directory '/home/ubuntu/go/src/github.com/vulsio/go-exploitdb'
pkill exploitdb.old
pkill exploitdb.new