search

vulsio / goval-dictionary

Build a local copy of OVAL. Server mode for easy querying.
Apache License 2.0
88 stars 60 forks source link

MariaDB support #412

Open robertsilen opened 3 months ago

robertsilen commented 3 months ago

Any particular reason MariaDB is not mentioned as supported database in the README? Would it be ok to add it with a PR?

This is part of my efforts I describe in my blog Improving MariaDB Support in Open Source Projects.

robertsilen commented 2 months ago

Made PR https://github.com/vulsio/goval-dictionary/pull/414 now, hope it is ok?

MaineK00n commented 2 months ago

MariaDB is already supported. Set DBType to MySQL and write DBPath and it will work fine.

$ docker run --rm --name mariadb -d -e MARIADB_ROOT_PASSWORD=password -e MARIADB_DATABASE=test -p 3306:3306 mariadb
$ goval-dictionary fetch ubuntu 24.04 --dbtype mysql --dbpath "root:password@tcp(127.0.0.1:3306)/test?parseTime=true"
robertsilen commented 2 months ago

MariaDB is already supported. Set DBType to MySQL and write DBPath and it will work fine.

$ docker run --rm --name mariadb -d -e MARIADB_ROOT_PASSWORD=password -e MARIADB_DATABASE=test -p 3306:3306 mariadb
$ goval-dictionary fetch ubuntu 24.04 --dbtype mysql --dbpath "root:password@tcp(127.0.0.1:3306)/test?parseTime=true"

Awesome, thank you @MaineK00n . So it should be fine to add a mention of MariaDB to the README as per https://github.com/vulsio/goval-dictionary/pull/414 ? :)