search

vultisig / vultisig-android

Vultisig Android App
Apache License 2.0
4 stars 2 forks source link

BUG: No landscape mode on tablet #277

Open realpaaao opened 1 month ago

realpaaao commented 1 month ago

Describe the bug App is not possible to put in landscape mode for tablets. If in landscape mode and app is opened it goes back to portrait

Expected behavior landscape mode possible for tablets

Additional context Reference

yvebe commented 1 month ago

@realpaaao I disabled landscape mode earlier because we haven't tested it, and on phone screens, it mostly looks really bad right now :(

I can enable landscape mode, but for it to work properly, we'll need to check (and most likely fix) the UI on all screens.

It's maybe a bit too much to fix in one sitting, so I suggest we just enable landscape mode and then fix issues with the UI as they come. But I would prepare for a lot of them. Is that OK?

Also, we might need custom designs for some of those landscape screens.

realpaaao commented 1 month ago

@YGolybev I think we will have that problem from time to time as on andriod there are many different screen sizes... enababling it now without having it tested wouldn't make sense as it will very frustrating for the user. Can you schedule it into your plan, not top priority? To revise the current UI state of tablets and fixing it that it is in an acceptable state. Minor or special UI bugs can be tackled after.

johnnyluo commented 1 month ago

Let's not worry about landscape mode for now , keep as it is right now , until we have bandwidth in the future to make it work appropriately