search

vultisig / vultisig-android

Vultisig Android App
Apache License 2.0
6 stars 2 forks source link

ADD: UI/UX for password encryption of Vault share #394

Closed realpaaao closed 3 months ago

realpaaao commented 3 months ago

To improve security of backups let the user set a password to encrypt his vault share and let him verify the set password and add the possibility to review the password before encrypting. See figma for design:

image

aminsato commented 3 months ago

@johnnyluo Should I use aes to encrypt vault? (same as https://github.com/vultisig/vultisigner/pull/17/files) or is it just a ui and I should not implement a logic behind it?

@realpaaao Do we need to have the same ui for vault import to decrypt the vault before doing import?

realpaaao commented 3 months ago

@aminsato yes use aes for encyption, so we are congruent with vultisigner and iOS and implement logic so user can encrypt and decrypt vault shares after merging this PR.

No we don't need same UI for decryption as we use the import UI screen and just prompt the password input, here is iOS for comparison: image

Also please consider that when user inputs wrong password that they do not need to load the file into vultisig again and just ask for re entering the password.