vultisig / vultisig-android

Vultisig Android App
Apache License 2.0
4 stars 2 forks source link

BUG: A lot screens get cut off on my Pixel 8 #483

Closed johnnyluo closed 2 days ago

johnnyluo commented 3 days ago
aminsato commented 3 days ago

This issue was related to the line:

https://github.com/vultisig/vultisig-android/blob/e462a6772c857df9c23cc929ec65d94d3fc74bf2/app/src/main/java/com/vultisig/wallet/app/activity/MainActivity.kt#L38

If we remove that line, we don't face the issue. This line was added in PR #477 to resolve the issue in Issue #372. I removed the line, and everything is back to normal. Even the issue in Issue #372 is not faced anymore.

@yvebe Can I ask why the line is required ?

yvebe commented 3 days ago

@aminsato most likely something i failed to check. if removing it doesn't affect the fix in question, let's remove it

aminsato commented 2 days ago

BiometryAuth Screen Screenshot_20240701_102121

yvebe commented 2 days ago

Fixed by #488, #490