vultisig / vultisig-android

Vultisig Android App
Apache License 2.0
5 stars 2 forks source link

BUG: Importing new backups from iOS does not work #552

Closed realpaaao closed 4 weeks ago

realpaaao commented 1 month ago

Describe the bug When trying to import backups ( I suppose after we implemented passcode protection) it is not possible and on import the user always gets prompted to put in a password even if there is none.

To Reproduce Steps to reproduce the behavior:

  1. make backup on iOS/macOS
  2. import on android
  3. See error

Expected behavior Able to import and detect properly if share is password protected or not.

johnnyluo commented 1 month ago

this one is the same as https://github.com/vultisig/vultisig-android/issues/516 , it should have been fixed

https://github.com/vultisig/vultisig-android/pull/547

Let's keep this one , and verify it on a newer version

johnnyluo commented 1 month ago

This one is not been fixed , password protected vault backup still can't be imported , the root cause android is writing base64(encryped(json)), however ios is writing encrypted(json) , the ios one is binary , android is plain text

Let's leave it for now , once both side updated to use protobuf backup , it should be compatible

yvebe commented 4 weeks ago

Protobuf is implemented so compatibility should be there