search

vultisig / vultisig-ios

Vultisig iOS App
Apache License 2.0
14 stars 8 forks source link

[BUG] No proper deletion of files #795

Open realpaaao opened 2 months ago

realpaaao commented 2 months ago

Describe the bug When deleting the app on macOS the files will not get deleted properly, possibly due to missing permissions. The files saved in ~/Library/Containers/Vultisig will not be deleted. Leading to that all vaults and states will be restored after a new installation.

Expected behavior A clean deinstallation of the application.

-V35

johnnyluo commented 2 months ago

Steps to delete the data.

  1. Open a terminal
  2. cd /Users/{You username}/Library/Containers/com.vultisig.wallet/Data/Library/Application\ Support
  3. run command ls , you should see a file call default.store
  4. run command rm -rf default.store
  5. open Vultisig again , it should start clean
johnnyluo commented 2 months ago

We are using swiftdata , so the data is saved to these folders by apple , when user remove the app, these get left behind, I don't think there is a way for us request to remove from the app

realpaaao commented 2 months ago

@johnnyluo can we make a script, like you mentioned the last time and package it nicely so the user can uninstall like that?

johnnyluo commented 2 months ago

we could make a script to help delete the storage , but don't think we should run it by default , only when they need to.

I think it is good to leave the data there , as that's the default behaviour of MacOS , also just in case people remove the app by mistake , so they can re-install to get it back

realpaaao commented 2 months ago

Agree. Like a uninstaller