Rancher machine - Githubissues

vultr / docker-machine-driver-vultr

Vultr Driver Plugin for Docker Machine

MIT License

27 stars 11 forks source link

Rancher machine #25

Closed happytreees closed 1 year ago

happytreees commented 1 year ago

Description

This PR will update the docker-machine to use up-to-date dependencies, and refactor the code

Checklist:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you linted your code locally prior to submission?
[x] Have you successfully ran tests with your changes locally?

optik-aper commented 1 year ago

A couple lint issues:

machine/driver/driver.go:253:33: Error return value of `d.addSSHKeyToCloudInitUserData` is not checked (errcheck)
        d.addSSHKeyToCloudInitUserData()
                                      ^
machine/driver/helper.go:97:24: stringintconv: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) (govet)
    dockerPortAsString := string(d.DockerPort)
                          ^

optik-aper commented 1 year ago

Another one:

machine/driver/driver.go:222:16: Error return value of `d.createSSHKey` is not checked (errcheck)
    d.createSSHKey()
                  ^

optik-aper commented 1 year ago

closes #24