vultr / terraform-provider-vultr

Terraform Vultr provider
https://www.terraform.io/docs/providers/vultr/
Mozilla Public License 2.0
190 stars 65 forks source link

[BUG] - Issue with the Terraform s3 backend and documentation #426

Closed echoboomer closed 8 months ago

echoboomer commented 8 months ago

Describe the bug In the latest terraform release, 1.6.3 at time of testing, the endpoint parameter does not work anymore and it fails to init since it has been deprecated. It should be endpoints.s3 now.

Furthermore, a new parameter, skip_requesting_account_id, is required when configuring the s3 backend for use with Vultr. Otherwise, initialization fails.

This example works properly:

terraform {
  backend "s3" {
    bucket = "my-bucket"
    key    = "terraform.tfstate"
    endpoints = {
      s3 = "https://ewr1.vultrobjects.com"
    }
    region = "us-east-1"

    skip_requesting_account_id  = true
    skip_credentials_validation = true
  }
}

I think the docs simply need to be updated for use with whatever terraform version introduced this change. Forgive me if this has already been mentioned - feel free to close.

To Reproduce Steps to reproduce the behavior:

  1. Try using the provider for Vultr with existing settings outlined here.

Expected behavior terraform init should pass.

Screenshots image

Desktop (please complete the following information where applicable:

Additional context

Add any other context about the problem here.

optik-aper commented 8 months ago

Hello @echoboomer. That appears to be with the s3 backend which has documented:

endpoint - (Optional, Deprecated) Custom endpoint URL for the AWS S3 API. Use endpoints.s3 instead.

That doesn't appear to be related to the Vultr terraform provider so I'm going to close this.

echoboomer commented 8 months ago

@optik-aper thanks for following up. This was my bad for opening this without thinking since it surprised me when using a newer version of the AWS provider.

The one thing I'll ask is that the documentation on the page I linked should be updated to either notify users about this change in the backend configuration or update it.

optik-aper commented 8 months ago

@echoboomer I'll pass along the feedback. Thanks!