vultr / terraform-provider-vultr

Terraform Vultr provider

https://www.terraform.io/docs/providers/vultr/

Mozilla Public License 2.0

189 stars 65 forks source link

Update containter registry to add validation and a data source resource #493

Closed optik-aper closed 1 month ago

optik-aper commented 1 month ago

Description

Adds validation to the container registry resource
Fixes some logging discrepancies in the resource
Adds web docs for the resource
Adds a data source and the associated docs

Related Issues

Resolves #476

445

Checklist:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you linted your code locally prior to submission?
[x] Have you successfully ran tests with your changes locally?

F21 commented 1 month ago

Would love to have resources to create docker and kubernetes creds as well: https://www.vultr.com/api/#tag/Container-Registry/operation/create-registry-docker-credentials https://www.vultr.com/api/#tag/Container-Registry/operation/create-registry-kubernetes-docker-credentials

optik-aper commented 1 month ago

Would love to have resources to create docker and kubernetes creds as well: https://www.vultr.com/api/#tag/Container-Registry/operation/create-registry-docker-credentials https://www.vultr.com/api/#tag/Container-Registry/operation/create-registry-kubernetes-docker-credentials

I agree and I'll build them out in a different PR since they're kind of odd compared to the rest of the resource and I haven't decided how best to represent that in terraform.