vultr / vultr-cli

Official command line tool for Vultr services
Apache License 2.0
475 stars 76 forks source link

Consolidate pagination metadata nil pointer checks #410

Closed PaulSonOfLars closed 7 months ago

PaulSonOfLars commented 7 months ago

Description

Consolidate pagination metadata nil pointer checks, fixing a panic in the region availability lists (#408)

Related Issues

Fixes #408

Checklist:

github-actions[bot] commented 7 months ago

Unit Tests and Coverage

Show Output ``` ? github.com/vultr/vultr-cli/v3 [no test files] ```

Pusher: @PaulSonOfLars, Action: pull_request_target

optik-aper commented 7 months ago

@PaulSonOfLars I like what you're doing here. Thanks for submitting the PR. I'm gonna look at this more closely and think it through. It's probably going to need a rebase once my PR goes in, so if you want to hold off to push the lint fixes until then, that'd be swell.

PaulSonOfLars commented 7 months ago

@optik-aper no problem! Sure thing, let me know when your PR is in and I'll rework this one

optik-aper commented 7 months ago

Just merged it!

github-actions[bot] commented 7 months ago

Unit Tests and Coverage

Show Output ``` ? github.com/vultr/vultr-cli/v3 [no test files] ```

Pusher: @PaulSonOfLars, Action: pull_request_target

github-actions[bot] commented 7 months ago

Unit Tests and Coverage

Show Output ``` ? github.com/vultr/vultr-cli/v3 [no test files] ```

Pusher: @PaulSonOfLars, Action: pull_request_target

github-actions[bot] commented 7 months ago

Unit Tests and Coverage

Show Output ``` ? github.com/vultr/vultr-cli/v3 [no test files] ```

Pusher: @PaulSonOfLars, Action: pull_request_target