vultr / vultr-csi

Container Storage Interface (CSI) Driver for Vultr Block Storage
Apache License 2.0
40 stars 17 forks source link

fix typo in csi_plugin.id in csi-node.nomad.hcl #124

Closed const-tmp closed 1 year ago

const-tmp commented 1 year ago

fix typo "vultr-amd" -> "vultr-ams"

Description

Found a typo which can confuse someone. Tested that version with id = "vultr-amd" not work and id = "vultr-ams" works.

Related Issues

Checklist:

github-actions[bot] commented 1 year ago

Unit Tests and Coverage

Show Output ``` ? github.com/vultr/vultr-csi/cmd/csi-vultr-driver [no test files] === RUN TestCreateVolume time="2023-05-25T17:27:31Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode: ]" test="create volume" volume-name=volume-test-name time="2023-05-25T17:27:32Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10 --- PASS: TestCreateVolume (1.00s) === RUN TestDeleteVolume time="2023-05-25T17:27:32Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec time="2023-05-25T17:27:32Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec --- PASS: TestDeleteVolume (0.00s) === RUN TestPublishVolume --- PASS: TestPublishVolume (0.00s) === RUN TestUnPublishVolume time="2023-05-25T17:27:32Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088 time="2023-05-25T17:27:32Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088 --- PASS: TestUnPublishVolume (0.00s) === RUN TestDriverSuite --- PASS: TestDriverSuite (0.00s) PASS coverage: 18.9% of statements ok github.com/vultr/vultr-csi/driver 1.007s coverage: 18.9% of statements ```

Pusher: @const-tmp, Action: pull_request_target