search

vuntz / maildir-to-ics

4 stars 2 forks source link

fix broken DTSTART value type for DATE values #5

Closed aspiers closed 8 years ago

aspiers commented 10 years ago

Lines like

DTSTART:20140612

are invalid, because 20140612 is a DATE value type, whereas DTSTART's default value type is DATE-TIME.

http://icalvalid.cloudapp.net/ says

The value appears to be a 'date' value, but 'VALUE=DATE' was not specified.

Add a 'VALUE=DATE' parameter to the date-time value. See RFC 5545 section 3.3.5 for details.

but actually section 3.8.2.4. of the RFC is far more informative about this.

vuntz commented 8 years ago

We don't touch DTSTART entries anymore. If this is still valid (and I can see some of that in my files...) then it's a bug in what generates the original ics bits in the mails (likely groupwise). So WONTFIX for us :/

aspiers commented 8 years ago

Why WONTFIX? Wouldn't it be worth working around Groupwise brokenness, given that's the main use case for us?

vuntz commented 8 years ago

Does it actually break anything for you? If yes, then okay, I can add the workaround. But if not, then I'd prefer to not have to deal with it since I don't want to accumulate unneeded workarounds in there.

aspiers commented 8 years ago

I would have thought it did, otherwise there would be no good reason for me to report it ... but I can't remember what.

vuntz commented 8 years ago

@aspiers ah well. I've added the workaround for now. I do have events with that bug, and it didn't impact me, fwiw.

aspiers commented 8 years ago

Thanks! :)

aspiers commented 8 years ago

Thinking about this a bit more, I guess it would break all-day events, but ICBW.