vuongxuongminh / laravel-async

Package provide simple way to run code asynchronously for your Laravel application.
MIT License
154 stars 26 forks source link

fix: declaration compatibility of ParentRuntime::createProcess #43 #44

Closed peteradeojo closed 11 months ago

peteradeojo commented 11 months ago

Fixed the issue in #43 .

vuongxuongminh commented 11 months ago

Fixed the issue in #43 .

This changed incompatible with old versions of async, you should bump spatie async version to latest version.

peteradeojo commented 11 months ago

spatie/async is already at the latest @ v1.6.0 .

vuongxuongminh commented 11 months ago

I mean you should update the version of Spatie async in composer.json to ^1.6, currently this package requires ^1.5 so if our users using version 1.5, this change will cause an error.

peteradeojo commented 11 months ago

Fixed the issue in #43 .

peteradeojo commented 11 months ago

Version updated to 1.6

Sorry for the closing and reopening. I was trying to add a comment. Not really familiar with this open source of a thing

codecov-commenter commented 11 months ago

Codecov Report

Merging #44 (4352c45) into main (369b19a) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##               main      #44   +/-   ##
=========================================
  Coverage     75.33%   75.33%           
  Complexity       32       32           
=========================================
  Files             8        8           
  Lines           150      150           
=========================================
  Hits            113      113           
  Misses           37       37           
Flag Coverage Δ
phpunit 75.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Runtime/ParentRuntime.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

vuongxuongminh commented 11 months ago

Thank you @peteradeojo

peteradeojo commented 11 months ago

Thank you @peteradeojo

Thank you too for this package. I use it at work so it's important to me lol