search

vuori / linux-minidisc

Free software for accessing MiniDisc devices (fork with NetMD fixes—use upstream for HiMD devices)
GNU General Public License v2.0
45 stars 9 forks source link

Add netmd_acquire_dev and netmd_release_dev functions to support Sharp IM-DR420 (and possibly others) #8

Closed andyboeh closed 4 years ago

andyboeh commented 4 years ago

At least the Sharp IM-DR420 NetMD recorder only allows track downloads if exclusive access to the device has been requested. Otherwise, it rejects all secure commands with 0x0a.

This PR adds two new functions to libnetmd.c and calls them when sending a track. While it should not hurt other devices, I haven't tested this.

vuori commented 4 years ago

Looks basically good to me. Did you have any other devices than the Sharp to test this with? My Sony has battery contact issues, but I'll try to revive it if not.

andyboeh commented 4 years ago

I just tested sending tracks on my Sony MZ-N505, it works as previously. SonicStage doesn't seem to make a difference between Sony and Sharp devices anyway.

vuori commented 4 years ago

Ok, if Soncistage does it it should be as good as they come. Merging this here, looks like there might be movement upstream so hopefully we can have recording support there in the near future.

andyboeh commented 4 years ago

Thank you! While porting this to @cybercase's netmd-js, I also noticed that the Sharp does not support (or not accept) disabling track protection - the command is rejected with 0x08. Since the return value is ignored anyway, this is currently not an issue, but for future reference we should note that

Invictaz commented 4 years ago

@andyboeh this might help Hi-MD devices as well as they require exclusive access. The other option is that the discs can be viewed in the Windows Explorer. When Sonicstage requires exclusive access, the windows explorer route is closed iirc.

andyboeh commented 4 years ago

@Invictaz Interesting to know! Were you able to test this? Unfortunately, I don't own a Hi-MD device. I'm actually looking for one, but they are rather expensive...

Invictaz commented 4 years ago

@andyboeh well there still is no new Windows GUI build from the guys over at Linux-minidisc or @vuori I use an unofficial one by @thp but that is from years ago. So If someone compiles a Windows build for me with your fixes I will test it right away :+1: Maybe you can compile it for me. I have never compiled software lol.

andyboeh commented 4 years ago

Maybe you can compile it for me. I have never compiled software lol.

Sorry, I don't use Windows at all. However, the change has been ported to netmd-js and Web MiniDisc has been updated as well to support the devices. Maybe it does work with your HiMD player (ready-to-run version available at https://stefano.brilli.me/webminidisc/).

thshdw commented 4 years ago

@andyboeh well there still is no new Windows GUI build from the guys over at Linux-minidisc or @vuori I use an unofficial one by @thp but that is from years ago. So If someone compiles a Windows build for me with your fixes I will test it right away 👍 Maybe you can compile it for me. I have never compiled software lol.

@Invictaz I have a windows build (32bit) from the latest upstream and from @vuori release that I can send you so you can test.