search

vurtun / nuklear

A single-header ANSI C gui library
13.66k stars 1.11k forks source link

Fix a bug wherein combobox cannot be closed by clicking the header + Update documentation link to use Statically (CLEAN) #908

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hello,

Quick intro for @dumblob, I am a software engineer that really like nuklear (using it since early commits) and the concept of single-file library, I will try to be really active on nuklear and make it as clean as possible, and thus keep it always updated. Thanks @vurtun for his amazing work and thanks @dumblob for still being such an active maintainer. 💯

Some people actually create new accounts, make a pull request then forget to make it compliant, and then the pull request become abandoned. I am testing everything on multiple systems, backends, and on different scenarios, so If I feel that something had to be pushed upstream, I am going for it, many pull requests are doomed nowadays.

Here is the clean pull request (instead of #880, thanks @kamil-zubair for fixing the bug). Then you can close #879.

P.S. can we fix Travis CI already... :smile:

dumblob commented 4 years ago

Hi @eax0r that's amazing to hear. Just go ahead :wink:.

P.S. can we fix Travis CI already...

You know it already - make a PR and it's gone :smile:.