vusec / inspectre-gadget

InSpectre Gadget: in-depth inspection and exploitability analysis of Spectre disclosure gadgets
https://vusec.github.io/inspectre-gadget/
Apache License 2.0
39 stars 3 forks source link

Minor logging improvement #11

Closed andyhhp closed 10 months ago

andyhhp commented 10 months ago

It appears that forks are disabled, and I'm a read-only user (which is correct, I hasten to add), so I'm not sure how best to contribute fixes back. Here's a minor diagnostics improvement.

$ inspectre-gadget.git$ git show
commit 9e4bb66130e6b1091de8d7a582b3873f31d5d55b (HEAD -> diag)
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Fri Dec 22 00:01:13 2023

    [analysis] Print the gadget name as well as its address

    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff --git a/analyzer/analyzer.py b/analyzer/analyzer.py
index 28c6a9a04813..5e9f05395bb3 100644
--- a/analyzer/analyzer.py
+++ b/analyzer/analyzer.py
@@ -154,7 +154,7 @@ def analyse_gadget(proj, gadget_address, name, config, csv_filename, tfp_csv_fil
     """

     # Step 1. Analyze the code snippet with angr.
-    l.info(f"Analyzing gadget at address {hex(gadget_address)}...")
+    l.info(f"Analyzing gadget at address {hex(gadget_address)} {name} ...")
     s = Scanner()
     s.run(proj, gadget_address, config)
SanWieb commented 10 months ago

True point. I just enabled forks, so now you should be able to open a pull request, if not, let me know.