Closed SamStephens closed 6 months ago
Once I'm free, I will see what I can do
@vutran1710 if you're going to close this, you really should remove threaded support entirely. This bug means this library isn't safe to use in any real world multi-threaded scenario.
@vutran1710 if you're going to close this, you really should remove threaded support entirely. This bug means this library isn't safe to use in any real world multi-threaded scenario.
I made some drastic change and it should not happen again.
@vutran1710 if you're going to close this, you really should remove threaded support entirely. This bug means this library isn't safe to use in any real world multi-threaded scenario.
I made some drastic change and it should not happen again.
Oh that's great news. When you closed it as "not planned" I thought that meant the bug is still present. I'll test with my reproduction and confirm we're good.
@vutran1710 I cannot reproduce with my reproduction in the original issue description.
I'll start using the library in the threaded workloads where I encountered this issue, and if I see any problems I'll open another issue. But it looks like you've fixed this bug; thanks!
I'm afraid I only have a statistical reproduction of this, based on an issue I'm seeing in a real world application.
I ran the following code on Python 3.9, WSL2, AMD processor, and after a few hours it stopped printing.
The stack trace when I CTRL-C this is:
When I try and then exit ipython, it hangs, which would point to one of the threads the ThreadPoolExecutor creates being still live (which the stack trace also points to).