Closed vaharoni closed 6 months ago
Hi @vaharoni Tks for this wonderful fix!
Can you help fix the remaining lint fail?
Thanks @vutran1710, fixed the lint issues.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7a04d79
) 96.91% compared to head (5846c52
) 96.91%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When using a Redis Cluster, LUA scripts may strictly enforce the meaning of KEYS and ARGS. Specifically, strings in KEYS need to reflect keys in the Redis keyspace, and their hash portion is used to determine the slot where the key resides. The original LUA script conflated KEYS and ARGS. This caused CROSSSLOT errors. This PR separates KEYS and ARGS to avoid these issues.
This fixes issue https://github.com/vutran1710/PyrateLimiter/issues/126.