search

vutran1710 / PyrateLimiter

⚔️Python Rate-Limiter using Leaky-Bucket Algorithm Family
https://pyratelimiter.readthedocs.io
MIT License
347 stars 36 forks source link

Simplify Redis dependencies #78

Closed judahrand closed 2 years ago

judahrand commented 2 years ago

This'll actually need a change in signature since the RedisCluster can't take a ConnectionPool in init.

judahrand commented 2 years ago

@vutran1710 Why did you merge this when it fails the tests? This PR doesn't currently work afaik.

vutran1710 commented 2 years ago

@judahrand i was pretty sleepy, i canceled the release tho.

if you dont mind, please create a fix for it and also update your previous PR as well. thanks

judahrand commented 2 years ago

@judahrand i was pretty sleepy, i canceled the release tho.

if you dont mind, please create a fix for it and also update your previous PR as well. thanks

I think I'll just leave this one be - more trouble than it's worth for me given that:

a) the approach that should be taken in the change in signature is unclear b) I don't use the Redis version anyway