Closed D-Brox closed 1 year ago
LGTM, Thank you!
Quick unrelated comment... I've been testing basic image/container management with both podman and balena (since they have pretty much the same API endpoints as docker implemented) and it has been working great.
I haven't heard of balena before but looking into it seems really interesting. Cuts out the unnecessary parts of docker. As for podman it has a docker compat layer thats why it is working out of the box but if you want to use the podman specific features you might want to check out https://github.com/vv9k/podman-api-rs (shameless plug :-)
What did you implement:
I added the parameters
Hostname
,Domainname
,IpcMode
andPidMode
toContainerCreateOptsBuilder
, needed for container-host integration in my use-case, following the Docker API documentation.How did you verify your change:
I created a container with the new parameters and checked the behavior using
docker inspect
What (if anything) would need to be called out in the CHANGELOG for the next release:
Add parameters
Hostname
,Domainname
,IpcMode
andPidMode
toContainerCreateOptsBuilder