`InspectNetworkSettings::ports` and `InspectContainerHostConfig::port_bindings` need small type modification - Githubissues

vv9k / podman-api-rs

Rust interface to Podman (libpod).

MIT License

84 stars 11 forks source link

`InspectNetworkSettings::ports` and `InspectContainerHostConfig::port_bindings` need small type modification #148

Closed marhkb closed 1 year ago

marhkb commented 1 year ago

I just noticed that both fields need to be modified to Option<HashMap<String, Option<Vec<InspectHostPort>>>> to avoid a serialization error.

Steps to reproduce

Download image docker.io/chincheng/neofetch:latest
Create a container from this image
Try to inspect the container. It will fail.

Crate version: Current master (#3ec3d7c21c)
OS: Fedora Linux 37.20221218.0 (Silverblue)

Output of running podman version on the command line:

Client:       Podman Engine
Version:      4.3.1
API Version:  4.3.1
Go Version:   go1.19.2
Built:        Fri Nov 11 16:01:27 2022
OS/Arch:      linux/amd64

vv9k commented 1 year ago

Thank you for the report! Should be resolved by #150