search

vvalluri / googleimagesearch

Code path image search using google apis
0 stars 0 forks source link

Please review google image search app. Completed all the must and advanced and bonus user stories. Playing with UI now. /cc @codepathreview @thecodepath @nesquena #1

Open vvalluri opened 9 years ago

vvalluri commented 9 years ago

I am trying to get Image detail view fill the entire screen but given the memory constraints currently i am resizing it and using playing with scaletypes (eg: matrix shows a smaller image)

-- Added staggered image view for the grid

/cc @codepathreview @thecodepath @nesquena

codepathreview commented 9 years ago

@vvalluri Could you pls check your search api call and make sure it is working fine? I see a lot of duplicate results in the GIF. And pls submit a new GIF after you make corrections

vvalluri commented 9 years ago

Hi, When i run the app on my phone i don't see duplicate results but my emulator has some issue. I tried many times last two days. Thanks, Vamsi

On Wed, Sep 24, 2014 at 11:34 PM, CodePath Reviewers < notifications@github.com> wrote:

@vvalluri https://github.com/vvalluri Could you pls check your search api call and make sure it is working fine? I see a lot of duplicate results in the GIF. And pls submit a new GIF after you make corrections

— Reply to this email directly or view it on GitHub https://github.com/vvalluri/googleimagesearch/issues/1#issuecomment-56779085 .

codepathreview commented 9 years ago

Can you pls attach a fresh apk file to your github and let me know so that I can download that and test it directly on device? I am not able to run your project after cloning and the apk I got from bin folder also doesnt works.

Thanks Vibhor

vvalluri commented 9 years ago

Hi Vibhor, I have added the ImageSearch.apk file. I tried on my phone. Please let me know if there are any issues.

Thanks, Vamsi

codepathreview commented 9 years ago

:+1: Excellent work Vamsi, impressive stuff. A few notes after checking out the code:

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

vvalluri commented 9 years ago

Thanks for the feedback. Also thanks for reminding me about Parcelable, I took a note when Nathan talked about it but it completely skipped my mind. -vamsi

On Thu, Sep 25, 2014 at 10:35 AM, CodePath Reviewers < notifications@github.com> wrote:

[image: :+1:] Excellent work Vamsi, impressive stuff. A few notes after checking out the code:

  • Great work on organizing source code.
  • Nice to see you used action bar for searching
  • Good job on getting the Share functionality working
  • Great job implementing FilterDialogFragment for filters.
  • Good job using the ConnectivityManager to check for network availability
  • Properly reused the single base method in search activity to fetch results for both initial load and the pagination
  • Great job using staggered grid view for polishing the app UI.
  • Great job on getting panning and zooming work with TouchImageView
  • Consider using Parcelable instead of Serializable(benefits http://stackoverflow.com/questions/5550670/benefit-of-using-parcelable-instead-of-serializing-object/5551155#5551155 )

Also, here's a more detailed Project 2 Feedback Guide here https://gist.github.com/nesquena/44091e4727b154d04269 which covers the most common issues with this submitted project. Read through the feedback guide point-by-point https://gist.github.com/nesquena/44091e4727b154d04269 to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

— Reply to this email directly or view it on GitHub https://github.com/vvalluri/googleimagesearch/issues/1#issuecomment-56854730 .