nus-pe-bot
commented
3 years ago Team's Response
No response provided.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Duplicate patients can be added if their names are in lowercase
the same patient "John Doe", "john doe", "john Doe" etc with ALL the same information fields can be added. no error message indicating duplicate is shown.
steps to reproduce:
- add n/John Doe y/31122000 g/M p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 b/AB- h/169cm w/69kg t/bronchitis
- add n/john doe y/31122000 g/M p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 b/AB- h/169cm w/69kg t/bronchitis
- add n/john Doe y/31122000 g/M p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 b/AB- h/169cm w/69kg t/bronchitis
these 3 patients are the same but are added as unique patients
below are the screenshots:
these screenshots show that each profile has the same details
[original: nus-cs2103-AY2021S2/pe-interim#2890] [original labels: severity.Medium type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It is valid that our checking for duplicates is not fully comprehensive, but it was never designed to be tested in an antagonistic way; clearly it does not cover all cases, but even after fixing this case, there are still many ways that a duplicate name can slip into our system, for example, John Doe vs Doe John. etc
The goal of our app is to deliver our target audience a viable functional product, not to comprehensively cover every way that they can type a patient's name wrongly, hence we respectfully view that this is not in our scope
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: I do agree that it would be difficult to comprehensively cover all cases with regards to a person's name, but allowing for case-insensitivity in the name field is simply a basic requirement, and would allow a lot of accidental typos by the user to be caught.
The user may not realise that the patient's details (e.g. John) have already been keyed into system. The user could then proceed by keying in "john" in the name field, and the same person would be stored inside the system, leading to cluttering of information and wastage of space.
In addition, as person name is used as the identifier, more thought and care could have been put into the parsing of the name field.
Does not make sense for person name to be case-sensitive. I could add Shrek and shrek (with the exact same other fields).