search

vvangelovski / django-audit-log

Audit log for your Django models
Other
232 stars 93 forks source link

Fixed middleware classes. #47

Closed jeacaveo closed 5 years ago

jeacaveo commented 7 years ago

According to this links, middleware classes must extend django.utils.deprecation.MiddlewareMixin instead of object to avoid compatibility issues between MIDDLEWARE and MIDDLEWARE_CLASSES configurations:

This PR includes changes that allow middleware classes to be configured under MIDDLEWARE.

There's a deprecation warning when using `MIDDLEWARE_CLASSES':

?: (1_10.W001) The MIDDLEWARE_CLASSES setting is deprecated in Django 1.10 and the MIDDLEWARE setting takes precedence. Since you've set MIDDLEWARE, the value of MIDDLEW ARE_CLASSES is ignored.

oliverroick commented 6 years ago

This fix is really helpful. Newer middleware implementations don't support the old-style MIDDLEWARE_CLASSES setting anymore so people won't be able to use other middlewares together with django-audit-log. For example, we have a project where we can't upgrade django-simple-history to version 2.0.

Is there a way to move this forward and get the fix released? Can I help?

elbenfreund commented 6 years ago

Any news on this one?

nikolas commented 5 years ago

This was already applied to master here: https://github.com/vvangelovski/django-audit-log/commit/cf464319fbfec3fdbb252a82746f0db571d1c3ca

So this PR can be closed. I'll make a forked release and link to it here.

nikolas commented 5 years ago

https://github.com/ccnmtl/django-audit-log/releases/tag/0.8.0