vvdoogy / alembic

Automatically exported from code.google.com/p/alembic
Other
1 stars 0 forks source link

Alembic\AbcCoreOgawa\Foundation.h is written using precise types without namespaces #307

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I noticed that Ogawa is written assuming that stdint.h is included.  I say this 
because it uses precise type definitions such as uint32_t but without the 
standard "Alembic::Util::" prefix.

For example look at lines 158-170:

  // Index of the next sample to write
    uint32_t nextSampleIndex;

    // Index representing the first sample that is different from sample 0
    uint32_t firstChangedIndex;

    // Index representing the last sample in which a change has occured
    // There is no need to repeat samples if they are the same between this
    // index and nextSampleIndex
    uint32_t lastChangedIndex;

    // Index representing which TimeSampling from the ArchiveWriter to use.
    uint32_t timeSamplingIndex;

This will not compile on windows prior to Visual Studio 2010 unless you add the 
prefix or include a Windows compatible replacement for stdint.h (such as: 
https://code.google.com/p/msinttypes/source/browse/trunk/stdint.h )

Original issue reported on code.google.com by b...@exocortex.com on 22 May 2013 at 12:26

GoogleCodeExporter commented 8 years ago
Thanks for pointing this out, I've committed a fix here:
http://code.google.com/r/millerlucas-dev/source/detail?r=c974fe7fe559275f3714887
f53027bca649875c3&name=ogawa

Just the Util:: prefix is specified because all occurences are in the Alembic 
namespace.  (If Windows is confused by this let me know)

Original comment by miller.lucas on 22 May 2013 at 6:02

GoogleCodeExporter commented 8 years ago
This is great.  Thanks!

Original comment by neuralsoft@gmail.com on 23 May 2013 at 6:28

GoogleCodeExporter commented 8 years ago

Original comment by miller.lucas on 28 Aug 2013 at 4:50