search

vvo / chainit

Turn an asynchronous JavaScript api into an asynchronous chainable JavaScript api
Other
12 stars 4 forks source link

chainit 3: why a state machine and can it be externalized #16

Open vvo opened 9 years ago

vvo commented 9 years ago

Are you planning on doing it @kapouer?

I guess we need to decide on error handling otherwise we would introduce another breaking change

vvo commented 9 years ago

I really do not understand the state machine thingy. Why we need it in core.

As you saw with the webdriver example, it seems we should try to keep chainit as small as possible and do not introduce features that are only needed by some users.

Maybe a plugin system would be enough.

chainit.use(require('chainit-state'));

?

kapouer commented 9 years ago

Yes i'm planning to do it, but i'd like to address the two issues you raised before. I pushed chainit-3 branch and will merge it to master when those issues are dealt with. Are you ok with that ?

vvo commented 9 years ago

Yes no problem!