vvo / chainit

Turn an asynchronous JavaScript api into an asynchronous chainable JavaScript api
Other
12 stars 4 forks source link

performance issues #8

Closed christian-bromann closed 10 years ago

christian-bromann commented 10 years ago

after I upgraded the queue package and brought code back to work chainIt runs much slower after a time (observed in WebdriverJS). I think the problem appeared after commit 394fff482. It is maybe connected with the fact that I start the queue too often (see L35).

vvo commented 10 years ago

@christian-bromann this is more than a performance issue because the test suite fails after 10-15 tests. The compute launching the tests will hit 100% cpu from the nodejs process.

I think we should switch back to previous queue version for now.

Otherwise most people using current webdriver master will have big trouble. Which is bad.

christian-bromann commented 10 years ago

I already rolled back the ChainIt version in camme/webdriverjs (see 56fed84198)

vvo commented 10 years ago

no more relevant