search

vvo / gifify

😻 Convert any video file to an optimized animated GIF.
ISC License
6.18k stars 313 forks source link

Enhanced checking of the requirements... #26

Closed pjaspers closed 9 years ago

pjaspers commented 9 years ago

I tried rendering a gif with subtitles and ran into an error like this:

convert.im6: no decode delegate for this image format `/tmp/magick-dmhxdNv4' @ error/constitute.c/ReadImage/544.
convert.im6: no images defined `gif:-' @error/convert.c/ConvertImageCommand/3044.

This is because convert doesn't get any input from ffmpeg and this was caused because ffmpeg was not compiled with the libass flag.

So I added some extra dependency checking in the checkRequirements call.

This does seem to add roughly 0.02s to the app, based on my extensive (read: running the app with time, like an animal).

The resulting gif in all its glory:

WAT

vvo commented 9 years ago

@pjaspers This is truly awesome. Could you add a link to the readme requirements when something fails?

This + some refactoring if you are up to. Great job!!!

pjaspers commented 9 years ago

@vvo done and done.

vvo commented 9 years ago

Thanks a lot @pjaspers !! Nice job :)