search

vvo / gifify

😻 Convert any video file to an optimized animated GIF.
ISC License
6.22k stars 313 forks source link

Suggestion: crop video #56

Open mauron85 opened 8 years ago

mauron85 commented 8 years ago

Hi, outstanding work. Is it possible to add video cropping?

vvo commented 8 years ago

Yes, taking a PR to do so, if ffmpeg has it then we can do it.

mauron85 commented 8 years ago

yeah. ffmpeg does have it https://ffmpeg.org/ffmpeg-filters.html#crop so should be possible

vvo commented 8 years ago

Ok, have a look at the code, you might be surprised how easy it can be to add

mauron85 commented 8 years ago

Definitely. :-) So is it now so, that you will implement it?

vvo commented 8 years ago

Sorry no I will not implement it, but I am really interested in it and I invite you to submit a pull request or having a try at it.

Clone the repo, type npm link in it (it will make gifify available globally), hack the code, try some videos, push a pull request!

mauron85 commented 8 years ago

I feel with you. From my own experience, I know how hard (impossible) is to convince people to do PR. I'll probably take look on it, when I find spare time between my biz and another open source project I'm working on.