search

vvo / gifify

😻 Convert any video file to an optimized animated GIF.
ISC License
6.18k stars 313 forks source link

Suggestion: throw error when resize option is not present #60

Open chasegiunta opened 7 years ago

chasegiunta commented 7 years ago

As it seems that the --resize option is a requirement (seen in my experience and #23) , maybe throw an error if the parameter is not present in command. Unless this is a bug? Gifify will continue to run indefinitely, and not create a write file in location, if not the --resize option is not defined

vvo commented 7 years ago

Hi @ChaseGiunta --resize is not always needed strangely it seems. Only in some cases, would you mind digging a bit more to see why?

chasegiunta commented 7 years ago

Unfortunately I'm not skilled enough to do so, ha. I can provide the video files (.mp4) if that is of some use.

vvo commented 7 years ago

Yes drop them here so that someone can have a look. I have really no idea on what's going on

chasegiunta commented 7 years ago

Apologies, it looks like it does create a temp file... But it will continue to run indefinitely (I think, I didn't leave it go to because it quickly ate up 5GB for this 7mb .mp4) https://cl.ly/0F3C2S3G1a1I

vvo commented 7 years ago

Maybe there's an underlying bug somewhere in the dependencies stack