search

vvo / in-viewport

Get a callback when any element becomes visible in a viewport (body or custom viewport)
MIT License
276 stars 24 forks source link

Fix a Markdown link syntax #8

Closed tzi closed 9 years ago

tzi commented 9 years ago

Hi!

The PR is a small fix for a Markdown link syntax.

Thanks for sharing this project! Cheers, Thomas.

tzi commented 9 years ago

The travis-ci failed with this message:

Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.
vvo commented 9 years ago

Thanks, where are you using in-viewport?

tzi commented 9 years ago

We use it through lazyload on http://mapado.com. We digged the documentation, cause we had a hard time to implement the custom container ;) But everything's fine now!

Thanks again! Thomas.

vvo commented 9 years ago

Arg, sorry you had problems using the custom container part of lazyload, how could we improve the documentation? As you are a user maybe you have ideas.

tzi commented 9 years ago

Perhaps, we can explain in the documentation when we need to define a container. Our use case was a popin with its own scroll. We didn't understood that to detect when the images was visible in the screen, we could not use the document container if they had a parent with scroll. Is there any way to detect this parent automatically?

We can also precise that the lazy load with a custom container could not been defined in the head, obviously, so you can not use it easily with the onload attribute.

Cheers, Thomas.