vvo / lazyload

:bullettrain_front: Lazyload images, iframes, widgets with a standalone JavaScript lazyloader
https://vvo.github.io/lazyload/
MIT License
938 stars 158 forks source link

Misc changes #36

Closed gmarty closed 11 years ago

gmarty commented 11 years ago

This PR contains:

Though it should work theoretically, I couldn't run the tests, so please make sure everything is OK before merging.

vvo commented 11 years ago

Im not sure about changing my coding style of prototype to direct assign and anonymous functions.

prototype = {name: function(){}}

vs

prototype.name = function name() {}

I'm not confortable with erasing the prototype. Also, I'm not sure I still needs prototypes..

For the others commits, ok to merge.

gmarty commented 11 years ago

The main thing here is the use of date.now() and its polyfill. The rest is just a matter of coding standard/style.

As a singleton, your object probably don't need prototypes here.

vvo commented 11 years ago

Code completely reworked, pull request no more relevant.

Still, I now use grunt thanks to your first commit. And there's no more prototype things around.