vvo / tzdb

🕰 Simplified, grouped and always up to date list of time zones, with major cities
MIT License
772 stars 53 forks source link

What happened to Kiev? #267

Closed timjnh closed 1 year ago

timjnh commented 1 year ago

This is more of a question than an issue. In this commit Kiev was removed and Zaporozhye was added. I can't see that a similar change was made in the IANA db so I'm trying to understand why the change was made. This may be something I don't understand about the source of this data.

maxim-yurkiv commented 1 year ago

for me the same. npm command "generate" which is "babel-node generate.js" shows a warning.

valeriy-sokoloff commented 1 year ago

Seems like IANA renamed Europe/Kiev to Europe/Kyiv (check tzdata2022c archive). But this is a broken update, of course

NBaruK commented 1 year ago

Hi, the problem is in the version of the node (or browser). The tzdb package uses luxon package for time zone validation. The luxon package use native Intl API for mentioned validation. The Kyiv is a relatively new change. You need the latest version of the node with the new version Intl API. If you run generate with the latest node version, the Europe/Kyiv time zone is presented.

@vvo, please, can you update your node version, run generate and push the changes?

Thank you.

vvo commented 1 year ago

@NBaruK I am gonna try what you just suggested, hold on

vvo commented 1 year ago

@NBaruK done and a release should be out shortly

vvo commented 1 year ago

:tada: This issue has been resolved in version 6.71.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

NBaruK commented 1 year ago

Thank you very much <3.

timjnh commented 1 year ago

Woohoo! Thanks guys and good find!