Open mhamri opened 8 years ago
ok, thanks. I'll check this issue soon and update the gallery.
On Fri, Aug 19, 2016 at 11:12 AM, Mohammad Hossein Amri < notifications@github.com> wrote:
in jquery 3.10 instead of .load(funcName) we need to use .on("load",
funcName). I've tested unite gallery with tiles theme and it worked fine
You can view, comment on, or merge this pull request online at:
https://github.com/vvvmax/unitegallery/pull/102 Commit Summary
- fix a bug that make it incompatible with jquery 3.10
- fix jquery 3.10 bug
File Changes
- A .gitignore https://github.com/vvvmax/unitegallery/pull/102/files#diff-0 (5)
- M dist/js/unitegallery.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-1 (2)
- M dist/js/unitegallery.min.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-2 (11)
- M package/unitegallery/js/unitegallery.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-3 (2)
- M source/unitegallery/js/ug-common-libraries.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-4 (2)
Patch Links:
- https://github.com/vvvmax/unitegallery/pull/102.patch
- https://github.com/vvvmax/unitegallery/pull/102.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/pull/102, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_qcsWxxs0K9u1LVekaAh_fXbcLv-ks5qhWV4gaJpZM4JoPr7 .
thanks. fixed the issue. will update the version soon. no need to merge.
On Mon, Aug 22, 2016 at 5:13 PM, maxim vendrov vvvmax@gmail.com wrote:
ok, thanks. I'll check this issue soon and update the gallery.
On Fri, Aug 19, 2016 at 11:12 AM, Mohammad Hossein Amri < notifications@github.com> wrote:
in jquery 3.10 instead of .load(funcName) we need to use .on("load",
funcName). I've tested unite gallery with tiles theme and it worked fine
You can view, comment on, or merge this pull request online at:
https://github.com/vvvmax/unitegallery/pull/102 Commit Summary
- fix a bug that make it incompatible with jquery 3.10
- fix jquery 3.10 bug
File Changes
- A .gitignore https://github.com/vvvmax/unitegallery/pull/102/files#diff-0 (5)
- M dist/js/unitegallery.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-1 (2)
- M dist/js/unitegallery.min.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-2 (11)
- M package/unitegallery/js/unitegallery.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-3 (2)
- M source/unitegallery/js/ug-common-libraries.js https://github.com/vvvmax/unitegallery/pull/102/files#diff-4 (2)
Patch Links:
- https://github.com/vvvmax/unitegallery/pull/102.patch
- https://github.com/vvvmax/unitegallery/pull/102.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/pull/102, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_qcsWxxs0K9u1LVekaAh_fXbcLv-ks5qhWV4gaJpZM4JoPr7 .
in jquery 3.10 instead of .load(funcName) we need to use .on("load", funcName). I've tested unite gallery with tiles theme and it worked fine.
please note that I used visual studio to edit the repo, the minified version really minified to one line and .gitignore modified. i forgot to unstage them, please ignore them