vvvmax / unitegallery

Unite Gallery - Responsive jQuery Image and Video Gallery Plugin. Aim to be the best gallery on the web on it's kind. See demo here:
http://unitegallery.net
MIT License
531 stars 157 forks source link

Full Screen event on Touch not working on Chrome #135

Open abidCharlotte49er opened 7 years ago

abidCharlotte49er commented 7 years ago

We have recently noticed. Full Screen control is not working for Touch event on Chrome. Apparently Chrome is not recognizing Touchend or Touchstart events as User gestures and so it is not firing element.webkitRequestFullscreen(); the function call. Is there a known fix for this one before we spend time and work on this?

Here is the warning we see on our Console log. "Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture."

Thanks

Abid

vvvmax commented 7 years ago

HI, how you can test it on desktop? where you trace the error? the touch events are only in mobile, but no trace there available. can you trace it on ios chrome btw?

On Wed, Feb 15, 2017 at 7:18 PM, abidCharlotte49er <notifications@github.com

wrote:

We have recently noticed. Full Screen control is not working for Touch event on Chrome. Apparently Chrome is not recognizing Touchend or Touchstart events as User gestures and so it is not firing element. webkitRequestFullscreen(); the function call. Is there a known fix for this one before we spend time and work on this?

Here is the warning we see on our Console log. "Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture."

Thanks

Abid

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_jhB8E8y0LaU5PGZn_UWxgFA-aVVks5rczNhgaJpZM4MB_vF .

abidCharlotte49er commented 7 years ago

Hey Max, Happy Friday!!

Please see below image. In Chrome developer mode you can set it to touch mode and your mouse cursor now be in touch mode instead of pointer. Try to tap on the zoom icon you will see a warning / error on console as seen in the image.

Thank You

image

vvvmax commented 7 years ago

HI, have you checked it in the real mobile phone? in the real mobile phone it should work.

On Fri, Feb 17, 2017 at 6:44 PM, abidCharlotte49er <notifications@github.com

wrote:

Hey Max, Happy Friday!!

Please see below image. In Chrome developer mode you can set it to touch mode and your mouse cursor now be in touch mode instead of pointer. Try to tap on the zoom icon you will see a warning / error on console as seen in the image.

Thank You

[image: image] https://cloud.githubusercontent.com/assets/2357276/23074149/f5413f24-f505-11e6-886d-47f37b44a915.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-280701718, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_k5b2vIPJc3Vg5DhmbI7vpDLh-lVks5rdc5YgaJpZM4MB_vF .

abidCharlotte49er commented 7 years ago

Hi,

These this is not on Mobile phone but a laptop or touch device with Touch screen.

Thanks

On Mon, Feb 20, 2017 at 2:13 AM, Max Valiano notifications@github.com wrote:

HI, have you checked it in the real mobile phone? in the real mobile phone it should work.

On Fri, Feb 17, 2017 at 6:44 PM, abidCharlotte49er < notifications@github.com

wrote:

Hey Max, Happy Friday!!

Please see below image. In Chrome developer mode you can set it to touch mode and your mouse cursor now be in touch mode instead of pointer. Try to tap on the zoom icon you will see a warning / error on console as seen in the image.

Thank You

[image: image] https://cloud.githubusercontent.com/assets/2357276/23074149/f5413f24- f505-11e6-886d-47f37b44a915.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-280701718, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_ k5b2vIPJc3Vg5DhmbI7vpDLh-lVks5rdc5YgaJpZM4MB_vF

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-281004209, or mute the thread https://github.com/notifications/unsubscribe-auth/ACP4HOT6xiYZ81saeoZasMXztaxlx9Eaks5reT0ugaJpZM4MB_vF .

-- Abid Raleigh, North Carolina

vvvmax commented 7 years ago

oh, I don't have one to check, do you see problems there, or only in the emulator?

On Mon, Feb 20, 2017 at 5:53 PM, abidCharlotte49er <notifications@github.com

wrote:

Hi,

These this is not on Mobile phone but a laptop or touch device with Touch screen.

Thanks

On Mon, Feb 20, 2017 at 2:13 AM, Max Valiano notifications@github.com wrote:

HI, have you checked it in the real mobile phone? in the real mobile phone it should work.

On Fri, Feb 17, 2017 at 6:44 PM, abidCharlotte49er < notifications@github.com

wrote:

Hey Max, Happy Friday!!

Please see below image. In Chrome developer mode you can set it to touch mode and your mouse cursor now be in touch mode instead of pointer. Try to tap on the zoom icon you will see a warning / error on console as seen in the image.

Thank You

[image: image] https://cloud.githubusercontent.com/assets/2357276/23074149/f5413f24- f505-11e6-886d-47f37b44a915.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-280701718, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_ k5b2vIPJc3Vg5DhmbI7vpDLh-lVks5rdc5YgaJpZM4MB_vF

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-281004209, or mute the thread https://github.com/notifications/unsubscribe-auth/ ACP4HOT6xiYZ81saeoZasMXztaxlx9Eaks5reT0ugaJpZM4MB_vF .

-- Abid Raleigh, North Carolina

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-281114419, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_sSeQF1NZRFOOAkQOVXYX5WF01FDks5rebbjgaJpZM4MB_vF .

abidCharlotte49er commented 7 years ago

It happens on chrome developer tool and as well a real touch device. This used to work before it appears to me Chrome doesn't recognize touch event to enable full screen or something. Best way to test this is on Chrome browser with touch enabled in developer tools

Thanks

On Thu, Feb 23, 2017 at 2:00 PM, Max Valiano notifications@github.com wrote:

oh, I don't have one to check, do you see problems there, or only in the emulator?

On Mon, Feb 20, 2017 at 5:53 PM, abidCharlotte49er < notifications@github.com

wrote:

Hi,

These this is not on Mobile phone but a laptop or touch device with Touch screen.

Thanks

On Mon, Feb 20, 2017 at 2:13 AM, Max Valiano notifications@github.com wrote:

HI, have you checked it in the real mobile phone? in the real mobile phone it should work.

On Fri, Feb 17, 2017 at 6:44 PM, abidCharlotte49er < notifications@github.com

wrote:

Hey Max, Happy Friday!!

Please see below image. In Chrome developer mode you can set it to touch mode and your mouse cursor now be in touch mode instead of pointer. Try to tap on the zoom icon you will see a warning / error on console as seen in the image.

Thank You

[image: image] https://cloud.githubusercontent.com/assets/ 2357276/23074149/f5413f24- f505-11e6-886d-47f37b44a915.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-280701718, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_ k5b2vIPJc3Vg5DhmbI7vpDLh-lVks5rdc5YgaJpZM4MB_vF

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-281004209, or mute the thread https://github.com/notifications/unsubscribe-auth/ ACP4HOT6xiYZ81saeoZasMXztaxlx9Eaks5reT0ugaJpZM4MB_vF .

-- Abid Raleigh, North Carolina

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-281114419, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_ sSeQF1NZRFOOAkQOVXYX5WF01FDks5rebbjgaJpZM4MB_vF

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-282086901, or mute the thread https://github.com/notifications/unsubscribe-auth/ACP4HCYI3VvyitMw8XirzimYqnaahXozks5rfddSgaJpZM4MB_vF .

-- Abid Raleigh, North Carolina

Matiush007 commented 7 years ago

Hello. I confirm that the problem is observed in the latest version of chrome (56). As the mobile and PC

mrsphinx commented 7 years ago

Hi. It is not work in Chome 56.0.xxx on Android 6.0. Problem in function webkitRequestFullscreen.

If I call webkitRequestFullscreen on element in console it work. In Class UG... it is not work. Why?

P.S. it is not work also http://unitegallery.net/index.php?page=compact-bottom

vvvmax commented 7 years ago

HI Guys. just fixed the issue. Please look the latest version 1.7.45. please tell me if something will not work.

On Mon, Feb 27, 2017 at 10:23 AM, mrsphinx notifications@github.com wrote:

Hi. It is not work in Chome 56.0.xxx on Android 6.0. Problem in function webkitRequestFullscreen.

If I call webkitRequestFullscreen on element in console it work. In Class UG... it is not work. Why?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-282655988, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_tZdUggq8NEldUb4vIr8AXFzFATZks5rgogGgaJpZM4MB_vF .

abidCharlotte49er commented 7 years ago

Good Morning Max,

We have been using 1.7.14 before and I have replaced with 1.7.45 and my first impression it appears to be working fine. I did test on Chrome simulator as well as on our touch screen device. I'm yet to thoroughly review the changes. I have been busy with other works. I will keep you posted if I noticed anything else.

Thank You Have a great day !!

On Mon, Feb 27, 2017 at 9:41 AM, Max Valiano notifications@github.com wrote:

HI Guys. just fixed the issue. Please look the latest version 1.7.45. please tell me if something will not work.

On Mon, Feb 27, 2017 at 10:23 AM, mrsphinx notifications@github.com wrote:

Hi. It is not work in Chome 56.0.xxx on Android 6.0. Problem in function webkitRequestFullscreen.

If I call webkitRequestFullscreen on element in console it work. In Class UG... it is not work. Why?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135# issuecomment-282655988, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_ tZdUggq8NEldUb4vIr8AXFzFATZks5rgogGgaJpZM4MB_vF .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-282738816, or mute the thread https://github.com/notifications/unsubscribe-auth/ACP4HJ_P_dP57QBsXBBlxekGYqY2ObIHks5rguCygaJpZM4MB_vF .

-- Abid Raleigh, North Carolina

Matiush007 commented 7 years ago

Hi, Its work! On PC (Chome 56.0.xxx) and mobile android 4.2.2 (Chome 56.0.xxx). Nice

vvvmax commented 7 years ago

ok. cool. thanks for testing. good luck!

On Mon, Feb 27, 2017 at 10:42 PM, Matiush007 notifications@github.com wrote:

Hi, Its work! On PC (Chome 56.0.xxx) and mobile android 4.2.2 (Chome 56.0.xxx). Nice

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/135#issuecomment-282846778, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_u3ZTFReDXXpiTq20GXg0l6uh-33ks5rgzVRgaJpZM4MB_vF .

dharders commented 7 years ago

Hi, I'm having a similar issue but for mouse events. Version 1.7.45 is working for touch events now, but not when clicking the fullscreen icon with a mouse in Chrome or Firefox. IE, iOS and Android works though!

I created an issue here #139

Anyone else experience this too, or know of a workaround ?

Thanks!

sadd0o commented 7 years ago

Hello All,

I am facing the issue regarding this fullscreen API. I am applying API on the Canvas Element and it shows me the warning: Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture.

I am not sure what I am missing. Any idea please?

Thanks in advance Saddam

ispysoftware commented 7 years ago

same issue here

event: touchstart

Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture. Version 63.0.3239.52 (Official Build) beta (64-bit)

if you call it on touchend it works fine