search

vvvmax / unitegallery

Unite Gallery - Responsive jQuery Image and Video Gallery Plugin. Aim to be the best gallery on the web on it's kind. See demo here:
http://unitegallery.net
MIT License
530 stars 158 forks source link

Plugin stops propagation of all left/right arrow key presses events #40

Closed erinsasha closed 8 years ago

erinsasha commented 8 years ago

Hello Max!

I’ve noticed that Unitgallery catches left/right arrow key pressing events and stops their propagation. So when focus is in a textarea, the user can switch between rows by pressing up/down arrow key, but he/she can’t move cursor to left or right. Can you add some option, which will tell the plugin: catch left/right arrow key pressing events only, if Unitgallery element has :hover or :focus state or some sort of that?

vvvmax commented 8 years ago

hi, dont understand what you mean. can you please explain another time in different way? focus what?

On Tue, Nov 3, 2015 at 8:44 PM, erinsasha notifications@github.com wrote:

Hello Max!

I’ve noticed that Unitgallery catches left/right arrow key pressing events and stops their propagation. So when focus in a , user can switch between rows by pressing up/down arrow key, but he/she can’t move cursor to left or right.
Can you add some option, which will tell for plugin: catch left/right arrow key pressing events only, if Unitgallery element has :hover or :focus sate or some sort of that?

— Reply to this email directly or view it on GitHub https://github.com/vvvmax/unitegallery/issues/40.

erinsasha commented 8 years ago

Sorry it seems in my previous message the word “textarea” was hidden because it was wrapped as a tag. Also :hover or :focus in the message are CSS or jQuery selectors http://www.w3schools.com/cssref/css_selectors.asp. I mean that the plugin must catch keyboard events only when a user works with a gallery. For example, if you add textarea element into your …/source/index.html, it will not allow you left/right movement of the cursor.

vvvmax commented 8 years ago

HI. The gallery can't catch events from inside textarea, sorry. No plugin can.

On Wed, Nov 4, 2015 at 2:43 PM, erinsasha notifications@github.com wrote:

Sorry it seems in my previous message the word “textarea” was hidden because it was wrapped as a tag. Also :hover or :focus in the message are CSS or jQuery selectors http://www.w3schools.com/cssref/css_selectors.asp. I mean that the plugin must catch keyboard events only when a user works with a gallery. For example, if you add textarea element into your …/source/index.html, it will not allow you left/right movement of the cursor.

— Reply to this email directly or view it on GitHub https://github.com/vvvmax/unitegallery/issues/40#issuecomment-153709389.

vvvmax commented 8 years ago

Hi, Now I'm understand what you mean. Fixed the bug in current release. Please check.

erinsasha commented 8 years ago

It works. Thank you!

vvvmax commented 8 years ago

Cool! Good luck!

On Thu, Nov 5, 2015 at 12:06 PM, erinsasha notifications@github.com wrote:

It works. Thank you!

— Reply to this email directly or view it on GitHub https://github.com/vvvmax/unitegallery/issues/40#issuecomment-154014579.