search

vvvmax / unitegallery

Unite Gallery - Responsive jQuery Image and Video Gallery Plugin. Aim to be the best gallery on the web on it's kind. See demo here:
http://unitegallery.net
MIT License
530 stars 157 forks source link

Youtube video keeps playing in background after closing fullscreen "modal" view #81

Open barryroodt opened 8 years ago

barryroodt commented 8 years ago

Seems to be related to the following issue: https://code.google.com/p/gdata-issues/issues/detail?id=4697

Fixed locally by forcing https protocol for Youtube's "loadAPI"

g_ugFunctions.loadJs("https://www.youtube.com/player_api", false);

Of course now the problem is that if you're loading the gallery in a site via http, it cannot communicate with the https youtube embed - meaning that you cannot do a 'seek' to keep playing video from last position, it plays from the beginning again. Lesser of two evils imo.

Am willing to submit a pull request if necessary. But posting this here in case someone else experiences the same issue.

vvvmax commented 8 years ago

Oh, thanks. Ill look at it later

On Wednesday, June 8, 2016, Barry Roodt notifications@github.com wrote:

Seems to be related to the following issue: https://code.google.com/p/gdata-issues/issues/detail?id=4697

Fixed locally by forcing https protocol for Youtube's "loadAPI"

g_ugFunctions.loadJs("https://www.youtube.com/player_api", false);

Of course now the problem is that if you're loading the gallery in a site via http, it cannot communicate with the https youtube embed - meaning that you cannot do a 'seek' to keep playing video from last position, it plays from the beginning again. Lesser of two evils imo.

Am willing to submit a pull request if necessary. But posting this here in case someone else experiences the same issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/81, or mute the thread https://github.com/notifications/unsubscribe/AC_K_vuWsfBmCs-UfcCebAPTCCRVbNi1ks5qJtDfgaJpZM4IxBDt .

vvvmax commented 8 years ago

Thanks, made that change, will be released in the next version update.

On Sun, Jun 12, 2016 at 9:22 PM, maxim vendrov vvvmax@gmail.com wrote:

Oh, thanks. Ill look at it later

On Wednesday, June 8, 2016, Barry Roodt notifications@github.com wrote:

Seems to be related to the following issue: https://code.google.com/p/gdata-issues/issues/detail?id=4697

Fixed locally by forcing https protocol for Youtube's "loadAPI"

g_ugFunctions.loadJs("https://www.youtube.com/player_api", false);

Of course now the problem is that if you're loading the gallery in a site via http, it cannot communicate with the https youtube embed - meaning that you cannot do a 'seek' to keep playing video from last position, it plays from the beginning again. Lesser of two evils imo.

Am willing to submit a pull request if necessary. But posting this here in case someone else experiences the same issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/81, or mute the thread https://github.com/notifications/unsubscribe/AC_K_vuWsfBmCs-UfcCebAPTCCRVbNi1ks5qJtDfgaJpZM4IxBDt .