search

vvvmax / unitegallery

Unite Gallery - Responsive jQuery Image and Video Gallery Plugin. Aim to be the best gallery on the web on it's kind. See demo here:
http://unitegallery.net
MIT License
530 stars 158 forks source link

javascript-error when using jQuery >= 3.0.0. #94

Open Fiona-TU opened 8 years ago

Fiona-TU commented 8 years ago

When using jQuery 3.0.0, a javascript error gets triggered because of the usage of .load in line 2308 of unitegallery.js

.load got removed in jQuery 3.0.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed

I couldn't figure out how it is affecting the gallery's functionality but maybe it will become a problem in the future.

Since I think it's easy to fix, it would be nice seeing a fix in the next release

vvvmax commented 8 years ago

ok, thanks. I'll fix it, sure. I'll do it during in the next week (not I'm on vacation) and update the version.

On Mon, Jul 18, 2016 at 11:07 AM, Fiona-TU notifications@github.com wrote:

When using jQuery 3.0.0, a javascript error gets triggered because of the usage of .load in line 2308 of unitegallery.js

.load got removed in jQuery 3.0.0

https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed

I couldn't figure out how it is affecting the gallery's functionality but maybe it will become a problem in the future.

Since I think it's easy to fix, it would be nice seeing a fix in the next release

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/94, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_nUV7GAtoUaHlqT36601-NGPWv3eks5qWzQwgaJpZM4JOfQy .

vvvmax commented 7 years ago

HI, very sorry for the bug delay. fixed the issue. will update the version now.

On Mon, Jul 18, 2016 at 11:04 PM, maxim vendrov vvvmax@gmail.com wrote:

ok, thanks. I'll fix it, sure. I'll do it during in the next week (not I'm on vacation) and update the version.

On Mon, Jul 18, 2016 at 11:07 AM, Fiona-TU notifications@github.com wrote:

When using jQuery 3.0.0, a javascript error gets triggered because of the usage of .load in line 2308 of unitegallery.js

.load got removed in jQuery 3.0.0 https://jquery.com/upgrade-guide/3.0/#breaking-change- load-unload-and-error-removed

I couldn't figure out how it is affecting the gallery's functionality but maybe it will become a problem in the future.

Since I think it's easy to fix, it would be nice seeing a fix in the next release

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vvvmax/unitegallery/issues/94, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_K_nUV7GAtoUaHlqT36601-NGPWv3eks5qWzQwgaJpZM4JOfQy .