Open/Close (Display/Discard) a Window

[antongit]

• We call a window (or CollapsingHeader) Open when it is not collapsed or clipped.
• We call a window (or CollapsingHeader) Visible when it is displayed.

To actually create a window on the screen (to display it), we just enable an If region with the Window inside. The Window has IsVisible output pin that turns false when the Close button on the titlebar is clicked.

Here how ImGui defines it: https://github.com/ocornut/imgui/blob/5bb287494096461f90eb5d18135f7c4809efd2f5/imgui.h#L318

To Open / Close (display / discard) a window the patch looks like that:

HowTo Open And Close a Window.zip

Is it ok like that? @azeno , @gregsn What do think?

[azeno]

Hmm not sure, it doesn't feel intuitive yet. The naming is hard to grasp.

• Instead of Is Open: Channel<bool> I'd suggest Is Collapsed: Channel<bool>
• Instead of Has Close Button: bool I'd suggest Closing: Channel<Unit> - if provided the Close button is visible and if clicked will push into that channel. That should allow to build logic like a "Save Dialog" before the actual window is being setup. Didn't try it yet, but at least the information would be upstream and not below.
• Whether or not the whole Window is even present the If region approach could be ok - otherwise we'd probably need to re-think all widgets if there should be an easy way to hide one.

I've opened a branch with the two changes suggested above https://github.com/vvvv/VL.ImGui/tree/feature/window-with-closing-input

[antongit]

After checking the Issue with @azeno we came to conclusion:

• Window should have the same IsVisible and IsOpen (maybe differently named) pins as CollapsingHeader. And Window should also disappear if IsVisible false.
• Pin names:
  • Collapsed (Channel) Input instad of IsOpen.
  • Open (Channel) input instead of IsVisible.
  • IsVisible is Output

Open-Visible-Close-Issue.zip

[antongit]

Current state of the Pins:

Window

• Inputs:
  • Collapsed (Channel) instead of IsOpen.
  • Open (Channel) instead of IsVisible.
  • Closing (Channel) instead of Has Close Button (bool) - fires wenn X is pressed.
• Outputs:
  • IsVisible

CollapsingHeader, TreeNode

• Inputs:
  • Visible (Channel)
  • Open (Channel)
  • Closing (Channel)
• Outputs:
  • Is Visible
  • Is Open

Popup

• Inputs:
  • Open (Channel)
• Outputs:
  • Is Visible

Popup (Modal)

• Inputs:
  • Open (Channel)
  • Closing (Channel)
• Outputs:
  • Is Visible

TabItem

• Inputs:
  • Visible (Channel)
  • Active (Channel)
  • Closing (Channel)
• Outputs:
  • Is Visible
  • Is Active

[antongit]

After the call with @azeno and @gregsn it looks like, that we've finally got it with the pin names:

Additional unrelated issue:

• [x] Bounds / Position (Channel): when user changes UI, updates should be pushed to that channel

[antongit]

ImGui-Visible-Collapsed-Closing-Test.zip