TextureFX issue collection

[joreg]

General

• [ ] vvvv/VL.StandardLibs#125
• [x] vvvv/VL.StandardLibs#145
• [x] vvvv/VL.StandardLibs#146
• [x] Should the fader for Mix() be a float4?
• [x] Pin order has changed, see Keying help patch
• [x] make sure default sampler is Linear, AddressUVW=wrap. and then remove node: AssignDefaultSampler
• [x] vvvv/VL.StandardLibs#529
• [x] Custom Texture input doesn't work? See Halo (Gradient)
• [x] add GenerateMipmaps attribute vvvv/VL.StandardLibs#377
• [x] For sources with Renderformat set to Unorm subsequent filters fail
• [x] Placing any filter in the patch results in a runtime error: Attempted to divide by zero
• [x] Sort out InTex() vs. Sample() see https://github.com/vvvv/VL.StandardLibs/issues/279
• [x] missing ToGamma in pipeline
• [x] export doesn't seem to find texturefx nodes
• [x] Control input for Filters and Mixers for per-pixel modulation
• [x] make "TextureSource" attribute @tebjan
• [x] create Tunnels node: Rightclicking type enum pin -> throws exception @tebjan
• [x] Base shader change doesn't trigger node recompile

Nodes

• [x] ChangeFormat needs an sRGB path
• [x] DirectionalBlur has custom control texture
• [x] Implement conversion details as discussed in https://github.com/vvvv/VL.Stride/pull/395
• [x] Move gimmick nodes to external package? Currently slows down startup and parsing a lot. see also vvvv/VL.StandardLibs#180
• [x] no good standard Blur node yet, only BoxBlur and obscure ones, activate strides gaussian blur
• [x] Don't use dynamic loops in blur shader code, use dynamic defines or different implementations
• [x] Format of sources should be sRGB?!
• [x] Replace Blend with stride binary operator
• [x] Should keying inherit from FilterBase?

[joreg]

@tebjan to reproduce: "Pin order sometimes wrong and SetValue calls the wrong pin"

• open help of blurglow
• replace blurglow with blur
• rightclick apply pin of blur -> Error: Unable to cast object of type 'System.Boolean' to type 'VL.Stride.Shaders.ShaderFX.SetVar`1[Stride.Core.Mathematics.Vector4]'.

[joreg]

https://github.com/vvvv/VL.Stride/pull/395

core utils

• [x] ChangeFormat -> see PR395, add tag: convert
• [x] Resize (Absolut) -> input is Size (int2), add bicubic mode
• [x] Resize (Relative) -> input is Factor (float2), add bicubic mode
• [x] Crop -> inputs in pixels: Left, Top, Right, Bottom
• [x] ChannelKeying
• [x] ChromaKey
• [x] LumaKey
• [x] HSCB -> add tags: hue, saturation, contrast, brightness
• [x] Invert
• [x] Transform -> use custom sampler input to have it visible by default
• [x] Threshold -> rename color inputs to "Output Color A"...
• [x] LinearDepth
• [x] Levels
• [x] Coordinates -> consider splitting in 2
• [x] Median
• [x] BackgroundSubstraction
• [x] TextureInfo -> rename to (Advanced)?, also remove version from (Basic)

core sources

• [x] Color
• [x] Gradient
• [x] Noise
• [x] Halo
• [x] Halo (Gradient)

core artistic filters

• [x] Blur -> replace input2 with Control input
• [x] DirectionalBlur -> replace input2 with Control input
• [x] BlurGlow
• [x] BlurPerfector
• [x] BoxBlur -> consider removing
• [x] Sharpen
• [x] Edge
• [x] Mosaic
• [x] Metallica
• [x] Glow
• [x] Bump
• [x] Colorize
• [x] MapColor
• [x] DropShadow

core mixers

[tebjan]

closing this, converted the missing two tasks into issues.

[joreg]

• [x] Source: make all non-experimental
• [x] ColorPalette: Transform input -> float4x4
• [x] Utils: make ChangeFormat non-experimental
• [x] Mixer: Make all non-experimental
• [x] Blend: GPUIn
• [x] Remove Mix
• [x] Filter: make all non-experimental except: FXAA, BrightFilter
• [x] add experimental GaussianBlur, Bloom
• [x] remove SimpleBloom

[joreg]

@tebjan :

• [x] ConvertColor: Remove RGBA,H,S,V from Enum, add toHSL conversion.
• [x] GetChannel, SetChannel, JoinChannels, SplitChannels: (Channel 0, Channel 1,2,3 instead of R,G,B,A)
• [x] Results of the Sharpen look suspicious to me. Also: setting all to 0 results in blurred image. Anton will compare to beta.
• [x] Blur: bad quality.
• [x] Why Always generate Mips... is not optional?
• [x] Reference Halo (Gradient) is just white renderer. It looks like that DynamicTexture1D returns transparent image. Probably it wasn't meant like that.

@joreg

• [x] Control pin needs help text
• [x] Hatch (FromTexture): Color pin has (0,0,0,0) as Default. Should be gray?
• [x] Glow has Always generate Mips for Input 2, and there is even no Input 2.
• [x] Make Grayscale node with Vector3 pin to define gray mix.
• [x] UVOffset: Rename to Displace. Consider add Distort tag. Max Offset should be not 0,0 and its buggy.
• [x] Stripes has Random Seed pin and it is float32, but our seed pins are Seed and are Integer32. Should the Stripes follow the convention?

[antongit]

• [x] RandomSeed looks strange for Dissolve: indeed, removed it
• [x] RandomSeed is clamped [0,1] for Blood. Is it everywhere like that?: ja, makes kinda sense because it is essentially just a uv shift
• [x] Always Generate Mips for Input pin visible by default:
  • [x] BlurGlow
  • [x] ChannelKeying
  • [x] DropShadow
  • [x] Edge
  • [x] Metallica
  • [x] NormalGlow
  • [x] Sharpen
• [x] Always Generate Mips for Input 2 pin visible by default
  • [x] Anaglyph
  • [x] Kaleidoscope
  • [x] MapColor

Dissolve:

Please don't close the Issue. The corresponding Helppatches should be adjusted after the nodes are fixed.

[joreg]

updated all helps