search

vvvv / VL.StandardLibs

A collection of standard libraries for vvvv including VL.Stride, VL.Skia, VL.ImGui, msgpack.org[VL]
https://visualprogramming.net
GNU Lesser General Public License v3.0
35 stars 14 forks source link

`Style` and `Flags` pins for the ImGui region to control the DefaultWindow? #7

Closed antongit closed 1 year ago

antongit commented 1 year ago

At the moment, the DefaultWindow can't be styled and configured.

It looks like, adding a Style pin is easy, but adding Flags is not so easy, because there are some hardcoded flags for the DefaultWindow (like NoTitleBar, NoBringToFrontOnFocus, NoBackground....) and how they should play together with the user-defined flags...

Maybe Style pin is ok, but no Flags pin. If user wants a custom window, it should just place the Window?

Should Style pin be hidden by default?

@azeno, @gregsn - what do you think?

azeno commented 1 year ago

Hm what was again the idea behind that default window? To have an easy entry point, right? Well if that is the case, and I'm not happy with that particular default, then I'd say it's enough to simply disable it and use the normal Window node to build my own. But I think that option is currently not even there, see https://github.com/vvvv/VL.StandardLibs/issues/12

joreg commented 1 year ago

i don't see a reason not to add a Style input. the fullscreen window is a good default. being able to also style it improves the default even more. if it was not there, as soon as one wants to change the style they have to quite refactor (add ChildWindow + couple of nodes) the patch.