search

vvvv / VL.StandardLibs

A collection of standard libraries for vvvv including VL.Stride, VL.Skia, VL.ImGui, msgpack.org[VL]
https://visualprogramming.net
GNU Lesser General Public License v3.0
36 stars 14 forks source link

bounding sphere and box issue with primitives #86

Closed joreg closed 2 years ago

joreg commented 2 years ago

https://discourse.vvvv.org/t/stride-sphere-model-and-its-bounding-sphere/20534

joreg commented 2 years ago

the missing boundingsphere is due to missing copy here: https://github.com/stride3d/stride/blob/5093b7f91c37f3eee48ebdd21d822d96b38a1140/sources/engine/Stride.Rendering/Rendering/Mesh.cs#L35 ie. simply adding 

BoundingSphere = mesh.BoundingSphere;

solves this.

re boundingBox: it is actually there on the ModelComponent and the Mesh, just not on the Model. this is because we're using the creating a new model from the Mesh primitives and forget to copy boundingbox and boundingsphere over.

-> this should be done in our MeshModel patch

joreg commented 2 years ago

regarding BoundingSphere see: https://github.com/stride3d/stride/pull/1449