vvvv / VL.StandardLibs

A collection of standard libraries for vvvv including VL.Stride, VL.Skia, VL.ImGui, msgpack.org[VL]
https://visualprogramming.net
GNU Lesser General Public License v3.0
36 stars 14 forks source link

Control input on TextureFX issues. #97

Closed cloneproduction closed 2 years ago

cloneproduction commented 2 years ago

Hi,

while having a control input on every filter is a very good direction the problem is that it is apparently just a Lerp between the original and the result.

This become an issue for example with the Blur filter :

image

image

Maybe the control input shouldn't be inherited but more a convention as it has to be used differently in the code for different TextureFX.

joreg commented 2 years ago

"that it is apparently just a Lerp between the original and the result." yes, that is by design exactly what it is.

please add some more words to the images above. it is not really clear what you're trying to say.

cloneproduction commented 2 years ago

The control parameter isn't suppose to fade the original and the result, it is how much the function affects the original. This is obvious using Blur node, the control parameter just act as a fade instead of controlling the amount of blur.

Same for blur directional as seen here : image

joreg commented 2 years ago

"The control parameter isn't suppose to fade the original and the result". i'm afraid, as mentioned before, this is exactly what we designed it to be though. because this is a feature that can be applied equally to all filters. otherwise, as you mentioned, the value would work differently for each filter. and then it would be confusing to have one pin with always the same name that always behaves differently, right?

so for the Blur you see that we have an extra input for Strength that is independent of the Control.

now what can be argued indeed, is that more filters might need a kind of Strength input similar to the Blur. we'll take suggestions on such.

cloneproduction commented 2 years ago

now what can be argued indeed, is that more filters might need a kind of Strength input similar to the Blur. we'll take suggestions on such.

I wasn't talking about that. Nevermind.