Not compatible with datomic 1.0.6527

[favila]

Datomic 1.0.6527 added additional methods to the Connection interface related to io-stats to support the new arities of transact and transact async. The datomic.api/transact and transact-async wrappers seem to always use this new method, even if called with only one argument.

This means datomock fails with 1.0.6527. Exceptions look like this:

Uncaught exception, not in assertion.
Exception: java.lang.AbstractMethodError: Method datomock/impl/MockConnection.transact(Ljava/util/List;Ljava/lang/Object;)Ldatomic/ListenableFuture; is abstract
 at datomock.impl.MockConnection.transact (impl.clj:-1)
    datomic.api$transact.invokeStatic (api.clj:107)
    datomic.api$transact.doInvoke (api.clj:105)
    ...

A quick fix is to add the additional method signatures but ignore the io-stat argument:

(defrecord MockConnection [...]
  Connection
  ...
  (transact [this tx-data _] (.transact this tx-data))
  (transactAsync [this tx-data _] (.transact this tx-data))
  ...
)

[favila]

I added #11 to address this.

[favila]

For any future readers: A fork with this patch is available on clojars with coordinate [org.clojars.favila/datomock "0.2.2-favila1"]. We are already using it in our (large) datomock-using test suite with 1.0.6527 without any issues.

[svdo]

Thanks @favila! Would love it if a new release could be made from this repo as well, being the official one. Thanks in advance! :)

[dazld]

@favila thanks a ton - @vvvvalvalval any chance of a release to fix this?

[holyjak]

@vvvvalvalval could you be so very kind and release this fix? It blocks Fulcro from abandoning the old datomic-free for the new, truly free stuff. 🙏